Making S2gate of lab and lab_dev the same #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalan-motamedi
added
the
no changelog
arsalan-motamedi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #548 +/- ##
===========================================
- Coverage 90.57% 90.55% -0.02%
===========================================
Files 102 102
Lines 6183 6185 +2
===========================================
+ Hits 5600 5601 +1
- Misses 583 584 +1
Continue to review full report in Codecov by Sentry.
|
apchytr
reviewed
Feb 3, 2025
| @@ -39,7 +39,7 @@ class TwoModeSqueezedVacuum(Ket): | |||
| >>> from mrmustard.lab_dev import TwoModeSqueezedVacuum, S2gate, Vacuum | |||
|
|
|||
| >>> state = TwoModeSqueezedVacuum(modes=[0, 1], r=0.3, phi=0.2) | |||
| >>> assert state == Vacuum([0, 1]) >> S2gate([0, 1], r=0.3, phi=0.2) | |||
| >>> assert state == Vacuum([0, 1]) >> S2gate([0, 1], r=-0.3, phi=0.2) | |||
There was a problem hiding this comment.
Just confirming this means the squeezing parameter for S2gate is the negative of TwoModeSqueezedVacuum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
there is a discrepancy between lab and lab_dev in defining
S2gate: squeezing parameter of one is the negative of the other.Description of the Change:
Making
S2gateof lab and lab_dev compatible by changing the lab_dev one.Benefits:
Consistency.
Possible Drawbacks:
None
Related GitHub Issues:
None